Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Researcher Classes filters and table #1250

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

pjanik
Copy link
Member

@pjanik pjanik commented Mar 22, 2024

https://www.pivotaltracker.com/story/show/187185134
https://www.pivotaltracker.com/story/show/187185190

This PR adds basic UI for the Researcher Classes page, partially based on the User Report forms. Most likely will be changed significantly later, but it could be used for now as a base for further updates.

It uses API defined in this PR: #1249

@pjanik pjanik requested a review from dougmartin March 22, 2024 19:54
Base automatically changed from 187185134-researcher-classes-api to master March 25, 2024 09:46
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@@ -1,2 +1,7 @@
%div
%h1 Research Classes: #{@project.name}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why this file isn't named researcher_classes.haml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it's probably coming from my early tests. It'd make more sense. I'll rename it in the next PRs.

@dougmartin dougmartin merged commit 29dc4df into master Mar 25, 2024
8 of 9 checks passed
@dougmartin dougmartin deleted the 187185134-researcher-classes-filters-and-table branch March 25, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants