Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update external report form sorting/labeling [PT-186835600] #1248

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

dougmartin
Copy link
Member

  • All checkbox sections are now sorted
  • All checkbox sections are now in checkbox then label order

- All checkbox sections are now sorted
- All checkbox sections are now in checkbox then label order
@dougmartin dougmartin requested a review from pjanik March 20, 2024 20:51
Copy link
Member

@pjanik pjanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻
Btw, shouldn't we call 'downcase' in all sort_by calls?

@dougmartin
Copy link
Member Author

@pjanik I only added the sorting by downcase in the shared views that used tags. The cohorts and projects views both sort by project name (cohort#fullname is project name + cohort name) and the project case should be fine.

@dougmartin dougmartin merged commit cf77bd9 into master Mar 21, 2024
10 checks passed
@dougmartin dougmartin deleted the 186835600-sort-projects-and-cohort-checkboxes branch March 21, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants