Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add supports_researchers flag to external reports [PT-187221928] #1242

Merged

Conversation

dougmartin
Copy link
Member

The supports_researchers notes if the external report supports anonymized researcher views.

This flag is returned in the offerings api result.

This commit adds the flag to the mapped external reports data available to the React components but does not add logic to filter out the reports.

The new researcher views React components will need to filter out reports in future commits.

The supports_researchers notes if the external report supports anonymized researcher views.

This flag is returned in the offerings api result.

This commit adds the flag to the mapped external reports data available to the React components but does not add logic to filter out the reports.

The new researcher views React components will need to filter out reports in future commits.
@dougmartin dougmartin requested a review from pjanik March 14, 2024 11:06
Copy link
Member

@pjanik pjanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

I have a question, though. If the anonymization is done server-side, it could be quite opaque for most reports, correct? They wouldn't necessarily know whether they are displaying real student names or anonymized ones. Then, does this flag exist because some additional customization might be necessary, e.g. feedback in the Dashboard?

@dougmartin
Copy link
Member Author

@pjanik Yes - the current story I'm working on adds a researcher type to the Firebase JWT. This will be used in a future stories so the dashboards can use to change their UI based on the user type. We will also be updating the api controllers to anonymize data based on the portal user type in a future story.

This commit is really just to allow us to disable each external report until it has the capability to use the next JWT and we update the controllers.

@dougmartin dougmartin merged commit 11796c1 into master Mar 15, 2024
10 checks passed
@dougmartin dougmartin deleted the 187221928-add-researcher-option-to-external-reports branch March 15, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants