feat: Project Admins can manage Materials Collections [PT-187061879] #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougmartin
force-pushed
the
187061879-allow-matcol-project-admins
branch
from
2396e40
to
aedc7a7
Compare
Adds the ability for project admins to manage materials collections.
dougmartin
force-pushed
the
187061879-allow-matcol-project-admins
branch
from
aedc7a7
to
66e635b
Compare
scytacki
approved these changes
Feb 16, 2024
| @@ -9,7 +9,7 @@ | |||
| =f.text_field :name | |||
| %li | |||
| Project: | |||
| =f.collection_select :project_id, Admin::Project.order("name ASC"), :id, :name, :prompt => "Select project..." | |||
| =f.collection_select :project_id, @projects, :id, :name, :prompt => "Select project..." | |||
There was a problem hiding this comment.
It looks like this lost the sorting.
| @@ -1,4 +1,4 @@ | |||
| - extra_search_fields = select_tag :project_id, options_from_collection_for_select(Admin::Project.order("name ASC"), "id", "name", selected: params[:project_id]), prompt: "Select project..." | |||
| - extra_search_fields = select_tag :project_id, options_from_collection_for_select(@projects, "id", "name", selected: params[:project_id]), prompt: "Select project..." | |||
There was a problem hiding this comment.
might have also lost the sorting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for project admins to manage materials collections.