Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI test failures caused by ChromeDriver (PT-185924955) #1209

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

433eros
Copy link
Contributor

@433eros 433eros commented Aug 28, 2023

See story card PT-185924955 for more information

@scytacki scytacki self-requested a review August 28, 2023 19:59
Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try the more forward compatible solution described here:
titusfortner/webdrivers#247 (comment)

Basically remove webdrivers and upgrade selenium-webdriver. It sounds like it has to be version 4.11.0 for this approach to work.

@433eros
Copy link
Contributor Author

433eros commented Aug 28, 2023

@scytacki Dropping webdrivers and updating selenium-webdriver causes some code breakages in the CapybaraInitializer class: https://github.com/concord-consortium/rigse/actions/runs/6004648143/job/16285698049#step:17:454

@scytacki
Copy link
Member

@dougmartin can you help @433eros with this. It looks like the error is that an additional library (probably capybara) has to be updated. The first spec test failure is on this line: https://github.com/concord-consortium/rigse/blob/master/rails/spec/support/feature_helper.rb#L3

The cucumber tests with javascript started running, but didn't get far enough to tell if they would have the same problem.

Maybe the update is too big to tackle now, but I hopeful (since we brought things up to date recently) that updating won't be too bad.

@dougmartin
Copy link
Member

@scytacki @433eros sure - I'll try to fix it locally on my dev box and then update this PR with any working changes.

@dougmartin
Copy link
Member

@scytacki @433eros I tried updating the capybara gems here (df8aa5e) and we are still getting the same error.

I don't have time this week to dive into dependency hell - I suggest we add this to the T1 Tech Debt list and revert the last two commits to get back to a green build for now.

@433eros
Copy link
Contributor Author

433eros commented Aug 29, 2023

@scytacki & @dougmartin reverted to original PR state

@433eros 433eros requested a review from scytacki August 29, 2023 15:21
Fixes deprecation warning message:
"/home/runner/work/rigse/rigse/rails/spec/support/solr_spec_helper.rb:23:
warning: calling URI.open via Kernel#open is deprecated, call URI.open
directly or use URI#open"

See: https://github.com/concord-consortium/rigse/actions/runs/5728882369/job/15530837575#step:17:9
Try to fix CI warning: "Please set
`Webdrivers::Chromedriver.required_version = <desired driver version>`
to a known chromedriver version"

See: https://github.com/concord-consortium/rigse/actions/runs/5728882369/job/15530837575#step:17:12
wget is more suitable for downloading files than curl because it handles
interruptions by default
Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@433eros 433eros merged commit e1c80db into master Aug 29, 2023
10 checks passed
@433eros 433eros deleted the failing-ci-workflow branch August 29, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants