-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI test failures caused by ChromeDriver (PT-185924955) #1209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try the more forward compatible solution described here:
titusfortner/webdrivers#247 (comment)
Basically remove webdrivers and upgrade selenium-webdriver. It sounds like it has to be version 4.11.0 for this approach to work.
@scytacki Dropping |
@dougmartin can you help @433eros with this. It looks like the error is that an additional library (probably capybara) has to be updated. The first spec test failure is on this line: https://github.com/concord-consortium/rigse/blob/master/rails/spec/support/feature_helper.rb#L3 The cucumber tests with javascript started running, but didn't get far enough to tell if they would have the same problem. Maybe the update is too big to tackle now, but I hopeful (since we brought things up to date recently) that updating won't be too bad. |
df8aa5e
to
fdf2a6e
Compare
@scytacki & @dougmartin reverted to original PR state |
Fixes deprecation warning message: "/home/runner/work/rigse/rigse/rails/spec/support/solr_spec_helper.rb:23: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open" See: https://github.com/concord-consortium/rigse/actions/runs/5728882369/job/15530837575#step:17:9
Try to fix CI warning: "Please set `Webdrivers::Chromedriver.required_version = <desired driver version>` to a known chromedriver version" See: https://github.com/concord-consortium/rigse/actions/runs/5728882369/job/15530837575#step:17:12
wget is more suitable for downloading files than curl because it handles interruptions by default
fdf2a6e
to
3a74d85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
See story card PT-185924955 for more information