feat: Optimize collections listing [PT-185588012] #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to optimize the materials collection rendering when used on large collection pages like the NGSS Assessment Portal. Here are the changes that were made: - Styled Landing page content html textarea on the projects admin page to be full width, and taller and to use a monospace font. Previously it was a standard unstyled textarea. This just makes viewing and editing it easier. - Added optional opacity animation setting to existing cleanUpAssignViewAdjustment function in langing_page.html.haml. This was a request to ensure the content was visible when the each NGSS content area was revealed. - Added a public loadMaterialsCollections() method which caches the results for later use in renderMaterialsCollection(). The api endpoint already supported getting multiple collections. - Fixes a race condition between the MaterialsCollection onDataLoad callback prop and the initial mount of the component. The existing code in the project landing pages assumes the component is mounted.
emcelroy
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Looks good to me 👍
Good call on the landing page content html textarea styling. We should've done that a long time ago. If it's not too much trouble, maybe do the same for the textareas in the following?
- rails/app/views/admin/settings/_home_page_content_field.html.haml
- rails/app/views/admin/settings/_help_page_item.html.haml
- rails/app/views/admin/settings/_about_page_content_field.html.haml
Definitely not required, though, if you don't have the time.
…t font to monospace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to optimize the materials collection rendering when used on large collection pages like the NGSS Assessment Portal.
Here are the changes that were made: