Skip to content

Commit

Permalink
fix: Try dropping webdrivers Gem
Browse files Browse the repository at this point in the history
  • Loading branch information
433eros committed Aug 28, 2023
1 parent fdf2a6e commit bd4d53f
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 28 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ jobs:
TEST_SOLR_PORT: 8981
env:
RAILS_ENV: ${{ matrix.env }}
CHROMEDRIVER_VERSION: '114.0.5735.90'
defaults:
run:
working-directory: ./rails/
Expand All @@ -77,16 +76,6 @@ jobs:
with:
bundler-cache: true # use Actions cache to significantly speed up subsequent runs
working-directory: ./rails/
# Install ChromeDriver (wiping out whatever version was previously installed on Actions Runner)
- name: Install ChromeDriver
uses: nanasess/setup-chromedriver@v2
with:
chromedriver-version: ${{ env.CHROMEDRIVER_VERSION }}
# Install Google Chrome browser (that matches ChromeDriver version from previous Actions step)
- name: Install Google Chrome
run: |
wget -O /tmp/google_chrome.deb https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_${CHROMEDRIVER_VERSION}-1_amd64.deb
sudo dpkg -i /tmp/google_chrome.deb

- run: cp -v ./config/database.github_actions.yml ./config/database.yml
- run: cp -v ./config/app_environment_variables.sample.rb ./config/app_environment_variables.rb
Expand Down
1 change: 0 additions & 1 deletion rails/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ group :test, :cucumber do
gem 'selenium-webdriver'
gem 'spring-commands-cucumber'
gem 'spring-commands-rspec'
gem 'webdrivers', '~> 3.0'
gem 'webmock', require: false
end

Expand Down
16 changes: 6 additions & 10 deletions rails/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ GEM
capybara-screenshot (1.0.25)
capybara (>= 1.0, < 4)
launchy
childprocess (3.0.0)
chronic (0.10.2)
ci_reporter (2.0.0)
builder (>= 2.1.2)
Expand Down Expand Up @@ -461,7 +460,7 @@ GEM
ruby-debug-base (0.10.4)
linecache (>= 0.3)
ruby_dep (1.5.0)
rubyzip (1.2.3)
rubyzip (1.3.0)
sanitize (5.2.3)
crass (~> 1.0.2)
nokogiri (>= 1.8.0)
Expand All @@ -477,9 +476,10 @@ GEM
sprockets (> 3.0)
sprockets-rails
tilt
selenium-webdriver (3.142.7)
childprocess (>= 0.5, < 4.0)
rubyzip (>= 1.2.2)
selenium-webdriver (4.9.0)
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
shellany (0.0.1)
simplecov (0.16.1)
docile (~> 1.1)
Expand Down Expand Up @@ -533,16 +533,13 @@ GEM
equalizer (~> 0.0, >= 0.0.9)
warden (1.2.9)
rack (>= 2.0.9)
webdrivers (3.9.4)
nokogiri (~> 1.6)
rubyzip (~> 1.0)
selenium-webdriver (~> 3.0)
webmock (3.13.0)
addressable (>= 2.3.6)
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)
webrick (1.7.0)
webrobots (0.1.2)
websocket (1.2.9)
websocket-driver (0.7.5)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
Expand Down Expand Up @@ -649,7 +646,6 @@ DEPENDENCIES
useragent
uuidtools (~> 2.1.2)
virtus (~> 1.0.3)
webdrivers (~> 3.0)
webmock
will_paginate
yui-compressor
Expand Down
1 change: 0 additions & 1 deletion rails/spec/spec_helper_common.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
require 'factory_bot'
FactoryBot.definition_file_paths = %w(factories)

require 'webdrivers'
require 'rspec/rails'
require 'rspec/mocks'
require 'capybara/rspec'
Expand Down
5 changes: 0 additions & 5 deletions rails/spec/support/capybara_initializer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ def call
Capybara.server_port = '43447'
end

# ChromeDriver version shipped with GitHub Actions: https://github.com/actions/runner-images/blob/d5d4c565dffff750a33f0f7d020bc12a4a896d90/images/linux/Ubuntu2204-Readme.md?plain=1#L158
# Latest ChromeDriver version available for download: https://chromedriver.storage.googleapis.com/LATEST_RELEASE
# See: https://github.com/hitobito/hitobito/blob/c5a459a95feefc32f7caa4c3bd5b36c7cb149916/spec/spec_helper.rb#L190-L196
Webdrivers::Chromedriver.required_version = '114.0.5735.90' # Pin ChromeDriver version

# Register the driver
Capybara.register_driver(:selenium) { |app| driver(app) }
Capybara.javascript_driver = :selenium
Expand Down

0 comments on commit bd4d53f

Please sign in to comment.