fix: Removed annotation caching [PT-185363141] #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash when comments are deleted. This also fixes broken comment moves, selection and text updates. A some point a change was made that caused the cache to get out of sync with the canvas. This removes the cache and instead reads directly from the canvas.
dougmartin
force-pushed
the
185363141-fix-annotations
branch
from
be228f9
to
deea66a
Compare
dougmartin
changed the title
pjanik
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash when comments are deleted. This also fixes broken comment moves, selection and text updates.
A some point a change was made that caused the cache to get out of sync with the canvas. This removes the cache and instead reads directly from the canvas.