Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle invalid data when running scripts #2414

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

scytacki
Copy link
Member

  • documentMetadata is undefined sometimes
  • some comment docs had tags as an empty string

- documentMetadata is undefined sometimes
- some comment docs had tags as an empty string
Copy link

cypress bot commented Sep 24, 2024

collaborative-learning    Run #13850

Run Properties:  status check passed Passed #13850  •  git commit b5c6d7435e: handle invalid data when running scripts
Project collaborative-learning
Branch Review 188212279-handle-invalid-data
Run status status check passed Passed #13850
Run duration 01m 41s
Commit git commit b5c6d7435e: handle invalid data when running scripts
Committer Scott Cytacki
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.33%. Comparing base (21fad09) to head (b5c6d74).
Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (21fad09) and HEAD (b5c6d74). Click for more details.

HEAD has 17 uploads less than BASE
Flag BASE (21fad09) HEAD (b5c6d74)
cypress-regression 5 0
cypress 12 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2414       +/-   ##
===========================================
- Coverage   86.28%   54.33%   -31.96%     
===========================================
  Files         741      732        -9     
  Lines       38220    38069      -151     
  Branches     9772     9750       -22     
===========================================
- Hits        32979    20685    -12294     
- Misses       4940    16355    +11415     
- Partials      301     1029      +728     
Flag Coverage Δ
cypress ?
cypress-regression ?
cypress-smoke 27.82% <ø> (+<0.01%) ⬆️
jest 48.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scytacki scytacki marked this pull request as ready for review September 24, 2024 17:24
Copy link
Member Author

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to run the regression tests on this since only scripts are changed.

Copy link
Contributor

@bgoldowsky bgoldowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@scytacki scytacki merged commit affff78 into master Sep 26, 2024
11 of 12 checks passed
@scytacki scytacki deleted the 188212279-handle-invalid-data branch September 26, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants