-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle invalid data when running scripts #2414
Conversation
scytacki
commented
Sep 24, 2024
- documentMetadata is undefined sometimes
- some comment docs had tags as an empty string
- documentMetadata is undefined sometimes - some comment docs had tags as an empty string
collaborative-learning Run #13850
Run Properties:
|
Project |
collaborative-learning
|
Branch Review |
188212279-handle-invalid-data
|
Run status |
Passed #13850
|
Run duration | 01m 41s |
Commit |
b5c6d7435e: handle invalid data when running scripts
|
Committer | Scott Cytacki |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
1
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2414 +/- ##
===========================================
- Coverage 86.28% 54.33% -31.96%
===========================================
Files 741 732 -9
Lines 38220 38069 -151
Branches 9772 9750 -22
===========================================
- Hits 32979 20685 -12294
- Misses 4940 16355 +11415
- Partials 301 1029 +728
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to run the regression tests on this since only scripts are changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍