Department Tours form #189
Conversation
ghost
requested review from
|
This pull request introduces 9 alerts when merging 8b40e25 into 78b68c7 - view on LGTM.com new alerts:
|
|
This pull request introduces 9 alerts when merging a4e9f4a into 78b68c7 - view on LGTM.com new alerts:
|
ghost
linked an issue
There was a problem hiding this comment.
Great code in tours.py! There's a few changes requested here. Also, is it possible to combine all the migrations into a single migrations file since this is just for a single PR? There are also merge conflicts with master that need to be resolved! The Pipfile.lock file was deleted -- not sure why?
|
|
||
|
|
||
| class TourRequest(forms.ModelForm): | ||
| date = forms.DateField(widget=SelectDateWidget(), label='Desired Date') |
There was a problem hiding this comment.
It's currently possible to request a dept tour before the current time. We should add some sort of check in so that there's less confusion on both sides of the dept tour request e.g. Rehan reads the time is for last month and not this month and he has to reach out to the dept tour requester to confirm that they meant this upcoming month.
This applies to both the mm/dd/yyyy:
and to the hh/mm on the next line down:
|
|
||
| class TourRequest(forms.ModelForm): | ||
| date = forms.DateField(widget=SelectDateWidget(), label='Desired Date') | ||
| desired_time = forms.TimeField(help_text='hh:mm 24-hour time', label='Desired Time') |
There was a problem hiding this comment.
Since some students may be flying in from the East Coast or internationally, we should take into account time zones for scheduling a dept tour. Maybe specify that all of these times are in PST (-7:00 GMT) and/or put in some conversion like this https://www.timeanddate.com/worldclock/converter.html?iso=20200317T200000&p1=791. This particular website encodes listed time zones in the URL, so we can use that to our advantage!
No description provided.