Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

Commit

Permalink
remove component-install(1) --out flag. Closes #389
Browse files Browse the repository at this point in the history
  • Loading branch information
@tj
tj committed Oct 27, 2013
1 parent 21fd5a0 commit 6e1094a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions bin/component-install
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ program
.usage('[name ...]')
.option('-d, --dev', 'install development dependencies')
.option('-r, --remotes <urls>', 'remotes to try installing from')
.option('-o, --out <dir>', 'output components to the given <dir>', 'components')
.option('-f, --force', 'force installation even if previously installed')
.option('-p, --proxy', 'use a proxy, eg. http://localhost:3128')
.option('-v, --verbose', 'verbose output')
Expand Down Expand Up @@ -195,11 +194,11 @@ process.on('exit', function(){
*/

function install(name, version) {
touch(program.out);
touch('components');

// kick off installation
var pkg = component.install(name, version, {
dest: program.out,
dest: 'components',
force: program.force,
dev: program.dev,
proxy: program.proxy,
Expand Down

5 comments on commit 6e1094a

@micky2be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aouch, we were using this to build our apps

@jonathanong
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you need it?

@ronkorving
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, can we please get this back please?
Are there really any compelling reasons to have this removed besides "I think nobody should need this"?

We can have a debate on its necessity, but that should happen in public and before removing it.

@jonathanong
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to open an issue. i was against this commit at first, but i'm more for it as long as the builder improves.

@ronkorving
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #462

Please sign in to comment.