Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dev Workflow Docs #301

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Add Dev Workflow Docs #301

merged 4 commits into from
Oct 22, 2024

Conversation

willtebbutt
Copy link
Member

Addresses #268 . @sunxd3 would you mind taking a quick look at this and letting me know if it is clear? I feel like you have most experience developing Mooncake after me, so you are likely best positioned to judge this.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Contributor

github-actions bot commented Oct 21, 2024

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬──────────┬─────────────┬─────────┐
│                      Label │ Mooncake │   Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │   String │      String │  String │
├────────────────────────────┼──────────┼──────────┼─────────────┼─────────┤
│                   sum_1000 │     70.8 │      1.0 │        5.61 │ missing │
│                  _sum_1000 │     7.15 │ 347000.0 │        33.2 │ missing │
│               sum_sin_1000 │     2.27 │     1.72 │        10.6 │ missing │
│              _sum_sin_1000 │     2.64 │    243.0 │        13.1 │ missing │
│                   kron_sum │     60.1 │     3.93 │       201.0 │ missing │
│              kron_view_sum │     62.2 │     9.75 │       256.0 │ missing │
│      naive_map_sin_cos_exp │     2.53 │  missing │        7.12 │ missing │
│            map_sin_cos_exp │     2.72 │     1.43 │         6.0 │ missing │
│      broadcast_sin_cos_exp │     2.61 │     2.27 │        1.46 │ missing │
│                 simple_mlp │     2.98 │      1.3 │        8.17 │ missing │
│                     gp_lml │     5.73 │     1.58 │     missing │ missing │
│ turing_broadcast_benchmark │     3.83 │  missing │        24.3 │ missing │
│         large_single_block │     4.03 │   4240.0 │        30.1 │ missing │
└────────────────────────────┴──────────┴──────────┴─────────────┴─────────┘

1. Ensure that you have Revise.jl and TestEnv.jl installed in your default environment.
1. start the REPL, `dev` Mooncake.jl, and navigate to the top level of the Mooncake.jl directory.
1. `using TestEnv, Revise`. Better still, load both of these in your `.julia/config/startup.jl` file so that you don't ever forget to load them.
1. Run the following: `using Pkg; Pkg.activate("."); TestEnv.activate(); include("test/front_matter.jl");` to set up your environment.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a suggestion, just a anecdotal point from me: I configure VSCode to automatically do the Pkg.activate() for the package folder I open. But what you wrote is better as it assumes less.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know -- this is good to know.

@sunxd3
Copy link
Collaborator

sunxd3 commented Oct 22, 2024

All make sense, thanks Will. I use VSCode REPL integration quite often, particularly ctrl/shift+enter to execute code.

@willtebbutt
Copy link
Member Author

Thanks for the review @sunxd3 -- I'll merge when CI passes.

@willtebbutt willtebbutt merged commit f0c170e into main Oct 22, 2024
20 checks passed
@willtebbutt willtebbutt deleted the wct/dev-workflow-docs branch October 22, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants