Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeVar Bug #299

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix TypeVar Bug #299

merged 2 commits into from
Oct 21, 2024

Conversation

willtebbutt
Copy link
Member

I believe that this resolves #282 .

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/fwds_rvs_data.jl 96.52% <100.00%> (+0.04%) ⬆️

Copy link
Contributor

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬─────────┬─────────────┬─────────┐
│                      Label │ Mooncake │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │  String │      String │  String │
├────────────────────────────┼──────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │     71.9 │     1.0 │        5.41 │ missing │
│                  _sum_1000 │     6.82 │  1320.0 │        34.5 │ missing │
│               sum_sin_1000 │      2.3 │     1.7 │        10.6 │ missing │
│              _sum_sin_1000 │     2.71 │   270.0 │        13.6 │ missing │
│                   kron_sum │     81.2 │    4.79 │       265.0 │ missing │
│              kron_view_sum │     51.4 │    7.03 │       160.0 │ missing │
│      naive_map_sin_cos_exp │     2.53 │ missing │        7.52 │ missing │
│            map_sin_cos_exp │      2.7 │    1.54 │        5.96 │ missing │
│      broadcast_sin_cos_exp │      2.6 │     3.0 │        1.46 │ missing │
│                 simple_mlp │     7.52 │    3.24 │        11.8 │ missing │
│                     gp_lml │     11.1 │    6.31 │     missing │ missing │
│ turing_broadcast_benchmark │     3.77 │ missing │        26.8 │ missing │
│         large_single_block │     4.14 │  4260.0 │        31.4 │ missing │
└────────────────────────────┴──────────┴─────────┴─────────────┴─────────┘

@willtebbutt willtebbutt merged commit d4448d3 into main Oct 21, 2024
20 checks passed
@willtebbutt willtebbutt deleted the wct/typevar-bug branch October 21, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error in backward pass
1 participant