Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BLAS / LAPACK calls on x86 #298

Merged
merged 7 commits into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ concurrency:
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}
jobs:
test:
name: ${{ matrix.test_group }}-${{ matrix.version }}
name: ${{ matrix.test_group }}-${{ matrix.version }}-${{ matrix.arch }}
runs-on: ubuntu-latest
if: github.event_name != 'schedule'
strategy:
Expand All @@ -33,18 +33,25 @@ jobs:
- 'integration_testing/temporalgps'
version:
- '1'
arch:
- x64
include:
- test_group: 'basic'
version: '1.10'
arch: x64
- test_group: 'integration_testing/turing'
version: '1.10'
arch: x64
- test_group: 'basic'
version: '1.10'
arch: x86

steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
arch: x64
arch: ${{ matrix.arch }}
include-all-prereleases: false
- uses: julia-actions/cache@v2
- uses: julia-actions/julia-buildpkg@v1
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Mooncake"
uuid = "da2b9cff-9c12-43a0-ae48-6db2b0edb7d6"
authors = ["Will Tebbutt, Hong Ge, and contributors"]
version = "0.4.15"
version = "0.4.16"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down
4 changes: 3 additions & 1 deletion src/rrules/blas.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
blas_name(name::Symbol) = (Symbol(name, "64_"), Symbol(BLAS.libblastrampoline))
function blas_name(name::Symbol)
return (BLAS.USE_BLAS64 ? Symbol(name, "64_") : name, Symbol(BLAS.libblastrampoline))

Check warning on line 2 in src/rrules/blas.jl

View check run for this annotation

Codecov / codecov/patch

src/rrules/blas.jl#L1-L2

Added lines #L1 - L2 were not covered by tests
end

function wrap_ptr_as_view(ptr::Ptr{T}, N::Int, inc::Int) where {T}
return view(unsafe_wrap(Vector{T}, ptr, N * inc), 1:inc:N*inc)
Expand Down
Loading