Skip to content

Commit

Permalink
Fix BLAS / LAPACK calls on x86 (#298)
Browse files Browse the repository at this point in the history 
* Bump patch version

* Add a single x86 run of the basic tests

* fix ci

* Add architecture to name

* Try 32 bit on 1.10

* Revert change

* Undo reversion
  • Loading branch information
@willtebbutt
willtebbutt authored Oct 21, 2024
1 parent 0427a04 commit f7338d1
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
11 changes: 9 additions & 2 deletions .github/workflows/CI.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ concurrency:
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}
jobs:
test:
name: ${{ matrix.test_group }}-${{ matrix.version }}
name: ${{ matrix.test_group }}-${{ matrix.version }}-${{ matrix.arch }}
runs-on: ubuntu-latest
if: github.event_name != 'schedule'
strategy:
Expand All @@ -33,18 +33,25 @@ jobs:
- 'integration_testing/temporalgps'
version:
- '1'
arch:
- x64
include:
- test_group: 'basic'
version: '1.10'
arch: x64
- test_group: 'integration_testing/turing'
version: '1.10'
arch: x64
- test_group: 'basic'
version: '1.10'
arch: x86

steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
arch: x64
arch: ${{ matrix.arch }}
include-all-prereleases: false
- uses: julia-actions/cache@v2
- uses: julia-actions/julia-buildpkg@v1
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Mooncake"
uuid = "da2b9cff-9c12-43a0-ae48-6db2b0edb7d6"
authors = ["Will Tebbutt, Hong Ge, and contributors"]
version = "0.4.15"
version = "0.4.16"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down
4 changes: 3 additions & 1 deletion src/rrules/blas.jl
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
blas_name(name::Symbol) = (Symbol(name, "64_"), Symbol(BLAS.libblastrampoline))
function blas_name(name::Symbol)
return (BLAS.USE_BLAS64 ? Symbol(name, "64_") : name, Symbol(BLAS.libblastrampoline))
end

function wrap_ptr_as_view(ptr::Ptr{T}, N::Int, inc::Int) where {T}
return view(unsafe_wrap(Vector{T}, ptr, N * inc), 1:inc:N*inc)
Expand Down

2 comments on commit f7338d1

@willtebbutt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/117765

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.16 -m "<description of version>" f7338d13f5b4d22fdeb322cf3f02de7db3431ade
git push origin v0.4.16

Please sign in to comment.