-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring some utilities #153
base: main
Are you sure you want to change the base?
Conversation
We should also be able to used the get_start_message function instead of the following Lines 109 to 114 in 4745f72
|
clang-tidy review says "All clean, LGTM! 👍" |
Looked straightforward but for some reason the test_xcpp_kernel.py test fails for some reason. Need to have a look into it |
@vgvassilev @mcbarton I think this might have something to do with the patches in CppInterOp (y'all could help by confirming) cause through backtrace we get
|
Caught the bug here. Sadly I was looking at all places except the function I had changed (the stack trace didn't help and confused me even more). It's an error with how xeus deals with extract_filename function, so have to fix that upstream. |
Why the nightly builds succeed then? |
c89eac9
to
aaab509
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 81.83% 81.55% -0.29%
==========================================
Files 19 19
Lines 837 824 -13
Branches 91 86 -5
==========================================
- Hits 685 672 -13
Misses 152 152
|
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
Few utilities that we use are already implemented and tested through xeus. So we can just get rid of them !