Emscripten finds Development.Embed and not Python::Python

compiler-research · Mar 11, 2024 · 18f39be · 18f39be
1 parent b6444e3
commit 18f39be
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -196,6 +196,7 @@ jobs:
             -DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON            \
             ..
           EMCC_CFLAGS='-sERROR_ON_UNDEFINED_SYMBOLS=0' emmake make -j5
+
       - name: Setup tmate session
         if: ${{ failure() && runner.debug }}
         uses: mxschmitt/action-tmate@v3

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -314,7 +314,14 @@ macro(xeus_cpp_create_target target_name linkage output_name)
         set(XEUS_CPP_XEUS_TARGET xeus-static)
     endif ()
 
-    target_link_libraries(${target_name} PUBLIC ${XEUS_CPP_XEUS_TARGET} clangCppInterOp pugixml argparse::argparse xtl Python::Python)
+    target_link_libraries(${target_name} PUBLIC ${XEUS_CPP_XEUS_TARGET} clangCppInterOp pugixml argparse::argparse xtl)
+    if (EMSCRIPTEN)
+      # For some reason emscripten cannot find Python::Python.
+      target_link_libraries(${target_name} PUBLIC Development.Embed)
+    else()
+      target_link_libraries(${target_name} PUBLIC Python::Python)
+    endif()
+
     if (WIN32 OR CYGWIN)
         #
     elseif (APPLE)