-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variadic support for templates #324
base: main
Are you sure you want to change the base?
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 73.71% 73.68% -0.04%
==========================================
Files 8 8
Lines 3021 3025 +4
==========================================
+ Hits 2227 2229 +2
- Misses 794 796 +2
|
e87e146
to
9412530
Compare
clang-tidy review says "All clean, LGTM! 👍" |
9412530
to
2ef2734
Compare
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't seem to have tests for the new code.
There is an added unittest... It is still a draft though, will update with a case for |
No description provided.