Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variadic support for templates #324

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaronj0
Copy link
Collaborator

@aaronj0 aaronj0 commented Sep 19, 2024

No description provided.

@aaronj0 aaronj0 marked this pull request as draft September 19, 2024 11:19
Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.68%. Comparing base (12e6e69) to head (2ef2734).

Files with missing lines Patch % Lines
lib/Interpreter/CppInterOp.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   73.71%   73.68%   -0.04%     
==========================================
  Files           8        8              
  Lines        3021     3025       +4     
==========================================
+ Hits         2227     2229       +2     
- Misses        794      796       +2     
Files with missing lines Coverage Δ
lib/Interpreter/CppInterOp.cpp 79.50% <66.66%> (-0.07%) ⬇️
Files with missing lines Coverage Δ
lib/Interpreter/CppInterOp.cpp 79.50% <66.66%> (-0.07%) ⬇️

Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't seem to have tests for the new code.

@aaronj0
Copy link
Collaborator Author

aaronj0 commented Sep 20, 2024

We don't seem to have tests for the new code.

There is an added unittest... It is still a draft though, will update with a case for TemplateArgument::ArgKind::Pack which are the 2 lines missing coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants