Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAP-434 - Surface Address Picker In Data Mapping #117

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

conatus
Copy link
Member

@conatus conatus commented Jul 2, 2024

This allows the user to select the address picker when they map data across to a third party data source.

Description

In some situations, a postcode has ambiguous polling stations. In other implementations of this data set, the user is shown a dropdown so they can choose their specific address. We obviously can't do that when writing data across, so need to just allow CRMs to know this so they can show the user another path to find out their polling location.

See https://api.electoralcommission.org.uk/docs/endpoints/#postcode-search-results-found-3 for a situation where results are found.

See https://api.electoralcommission.org.uk/docs/endpoints/#postcode-search-address-picker-3 for a situation where a data picker is displayed.

It is useful to know this in, say, Action Network, to make decisions on what is shown in email templates. Imagining here we map over to an Action Network custom field called Polling Station Known.

{% if 'Polling Station Known' != "false" %}

Your polling station is:

{{ 'Nearest Polling Station Address' | form_value }}

Get Directions

{% else %}

Hit the link below to find your polling station:

...

{% endif %}

How Can It Be Tested?

  1. Roll it out.
  2. Add in the data source as required and test manually.

How Will This Be Deployed?

Usual continuous delivery process.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I've checked the spec (e.g. Figma file) and documented any divergences.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I've updated the documentation accordingly.
  • Replace unused checkboxes with bullet points.

@commonknowledge-bot commonknowledge-bot deployed to add_address_picker - meep-database PR #117 July 2, 2024 20:51 — with Render Active
@commonknowledge-bot commonknowledge-bot temporarily deployed to add_address_picker - meep-intelligence-hub-backend PR #117 July 2, 2024 20:53 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to add_address_picker - meep-intelligence-hub-backend PR #117 July 2, 2024 20:53 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to add_address_picker - meep-intelligence-hub-frontend PR #117 July 2, 2024 20:53 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot had a problem deploying to add_address_picker - meep-intelligence-hub-worker PR #117 July 2, 2024 20:53 — with Render Failure
@commonknowledge-bot commonknowledge-bot temporarily deployed to add_address_picker - meep-intelligence-hub-frontend PR #117 July 2, 2024 20:53 — with Render Destroyed
@conatus conatus requested a review from joaquimds July 2, 2024 20:56
@conatus conatus self-assigned this Jul 2, 2024
@conatus conatus changed the title Surface Address Picker In Data Mapping MAP-434 - Surface Address Picker In Data Mapping Jul 2, 2024
Copy link

linear bot commented Jul 2, 2024

@commonknowledge-bot commonknowledge-bot temporarily deployed to add_address_picker - meep-intelligence-hub-backend PR #117 July 2, 2024 20:58 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to add_address_picker - meep-intelligence-hub-worker PR #117 July 2, 2024 20:58 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to add_address_picker - meep-intelligence-hub-backend PR #117 July 2, 2024 21:00 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to add_address_picker - meep-intelligence-hub-worker PR #117 July 2, 2024 21:00 — with Render Destroyed
@conatus conatus merged commit bf27f5e into main Jul 3, 2024
3 checks passed
@conatus conatus deleted the add_address_picker branch July 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants