forked from mysociety/local-intelligence-hub
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAP-434 - Surface Address Picker In Data Mapping #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonknowledge-bot
deployed
to
add_address_picker - meep-database PR #117
July 2, 2024 20:51
— with
Render
Active
commonknowledge-bot
temporarily deployed
to
add_address_picker - meep-intelligence-hub-backend PR #117
July 2, 2024 20:53
— with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
add_address_picker - meep-intelligence-hub-backend PR #117
July 2, 2024 20:53
— with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
add_address_picker - meep-intelligence-hub-frontend PR #117
July 2, 2024 20:53
— with
Render
Destroyed
commonknowledge-bot
had a problem deploying
to
add_address_picker - meep-intelligence-hub-worker PR #117
July 2, 2024 20:53
— with
Render
Failure
commonknowledge-bot
temporarily deployed
to
add_address_picker - meep-intelligence-hub-frontend PR #117
July 2, 2024 20:53
— with
Render
Destroyed
conatus
changed the title
Surface Address Picker In Data Mapping
MAP-434 - Surface Address Picker In Data Mapping
Jul 2, 2024
commonknowledge-bot
temporarily deployed
to
add_address_picker - meep-intelligence-hub-backend PR #117
July 2, 2024 20:58
— with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
add_address_picker - meep-intelligence-hub-worker PR #117
July 2, 2024 20:58
— with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
add_address_picker - meep-intelligence-hub-backend PR #117
July 2, 2024 21:00
— with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
add_address_picker - meep-intelligence-hub-worker PR #117
July 2, 2024 21:00
— with
Render
Destroyed
joaquimds
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to select the address picker when they map data across to a third party data source.
Description
In some situations, a postcode has ambiguous polling stations. In other implementations of this data set, the user is shown a dropdown so they can choose their specific address. We obviously can't do that when writing data across, so need to just allow CRMs to know this so they can show the user another path to find out their polling location.
See https://api.electoralcommission.org.uk/docs/endpoints/#postcode-search-results-found-3 for a situation where results are found.
See https://api.electoralcommission.org.uk/docs/endpoints/#postcode-search-address-picker-3 for a situation where a data picker is displayed.
It is useful to know this in, say, Action Network, to make decisions on what is shown in email templates. Imagining here we map over to an Action Network custom field called
Polling Station Known
.How Can It Be Tested?
How Will This Be Deployed?
Usual continuous delivery process.
Types of changes
Checklist: