Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge: drain each socket up to a fixed number #33400

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Aug 29, 2024

The updated approach processes up to MAX_MESSAGES_PER_SOCKET before moving to the next one. This prevents any single socket from dominating processing and ensures a more balanced distribution of message handling, similar to what was done in loggerd.

resolve #32862 (comment):

@sshane: now PJ streaming looks rather choppy and sometimes skips a split second of data, can you take another look at this?

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sshane sshane merged commit 930fa18 into commaai:master Aug 29, 2024
17 checks passed
@deanlee deanlee deleted the bridget_drain_sock branch August 29, 2024 19:53
ZwX1616 pushed a commit that referenced this pull request Sep 13, 2024
drain each socket up to a fixed number
old-commit-hash: 930fa18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants