remove timezone from timed.py

[BBBmau]

Resolves #32662

Unfortunately when looking into the response we get when getting route info their isn't any mention of timezone ids. however we can use tilequery which does return the timezone id based on the coordinates, this can be another request within calculate_route in the RouteEngine class. I've started the implementation but also was curious as to whether this is fine since this does require making another request after the routeRequest is successful.

[github-actions]

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

• Convert your PR to a draft unless it's ready to review
• Read the contributing docs
• Before marking as "ready for review", ensure:
  • the goal is clearly stated in the description
  • all the tests are passing
  • the change is something we merge
  • include a route or your device' dongle ID if relevant

[adeebshihadeh]

Hmm, the API docs mention that this API is for extracting information from the tiles without rendering them... however we only care about knowing the timezone when rendering the map. Can we get them in the UI somehow when rendering the map?

[BBBmau]

Hmm, the API docs mention that this API is for extracting information from the tiles without rendering them... however we only care about knowing the timezone when rendering the map. Can we get them in the UI somehow when rendering the map?

looked into being able to use the existing api for rendering like you said but again it didn't look like it provided the timezone information like how tilequery does.

I went ahead and used the tilequery still and was able to get it to use param.get("Timezone") when initializing map_eta which is only done when map_panel is initialized.

Marking ready for review since tests are passing and I verified that it eta works fine by running ./replay --demo && ./ui locally.

[BBBmau]

Not sure what's causing simulator test to fail?

[maxime-desroches]

@BBBmau #32684 fixed the simulator

[adeebshihadeh]

Including the timezone in the nav packet, instead of using the Timezone param, has the added benefit of this codepath being hit every time. For example, if the timezone getting code broke, most people wouldn't notice until they reset the device or crossed a timezone borundary.

[adeebshihadeh]

Added to the 0.9.8 milestone. Might be a little bit before we get to it, but looks good at first glance

[adeebshihadeh]

Slight change of plans, this won't be needed after #32773. Let's just trim this down to removing timezone handling from timed, and I'll merge it after I merge #32773.

[BBBmau]

Slight change of plans, this won't be needed after #32773. Let's just trim this down to removing timezone handling from timed, and I'll merge it after I merge #32773.

makes sense, was thinking about this after seeing the work done on removing navigation.