update to new opendbc api #32009
Merged
update to new opendbc api #32009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
deanlee
force-pushed
the
opendbc_new_api
branch
6 times, most recently
from
b3023ad
to
512930f
Compare
deanlee
force-pushed
the
opendbc_new_api
branch
from
512930f
to
a0b1ac6
Compare
deanlee
commented
Mar 28, 2024
deanlee
force-pushed
the
opendbc_new_api
branch
3 times, most recently
from
6e01a48
to
2333bc7
Compare
|
This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity. |
deanlee
force-pushed
the
opendbc_new_api
branch
2 times, most recently
from
1713aa1
to
5841a77
Compare
|
trigger-jenkins |
|
Seeing same CPU usage in card which is great! |
|
Great to hear the CPU usage is the same! We can further reduce it later, like in pr commaai/opendbc#1046 |
|
trigger-jenkins |
sshane
reviewed
Jul 31, 2024
|
trigger-jenkins |
sshane
added a commit
that referenced
this pull request
Jul 31, 2024
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
* use new opendbc api * export pandad_python * merge master * merge master * bump opendbc * bump opendbc * improve func * keep interface unchanged * fix test_car_interfaces * bump opendbc * bump opendbc * fix test_models * the interface now has to convert from can capnp to list, so we should include this time * goes from ~210 to ~240 mean ms real time * remoe busTime * lowercase sendcan * consistent msgtype * bump * bump * not used in lat_mpc * space * bump to master --------- Co-authored-by: Shane Smiskol <[email protected]> old-commit-hash: 0dddc97
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
This reverts commit d21755b2e216c3f547db0b55b7088357c4368801. old-commit-hash: ac13000
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
This reverts commit f2f01e3afaeaa267af61c8d7ab918da04d3411f2. old-commit-hash: 7c11234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on commaai/opendbc#934
performance is twice as slow because of a few more data conversions. but it should be enough.
the results of running
selfdrive/debug/check_can_parser_performance.py:[updated]:
before:
after: