Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Toyota: learn offset for PCM acceleration request" #1463

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Nov 8, 2024

Reverts #1461

Need to get the aEgo delay thing figured out for high jerk scenarios, but on the right track. Reverting until it works in all cases

@sshane sshane marked this pull request as ready for review November 8, 2024 22:12
@sshane sshane merged commit dbe8213 into master Nov 8, 2024
5 checks passed
@sshane sshane deleted the revert-1461-toyota-learn-pcm-accel-v2-shippable branch November 8, 2024 22:12
@github-actions github-actions bot added car related to opendbc/car/ toyota labels Nov 8, 2024
@gregjhogan
Copy link
Member

High jerk may also cause the pitch of the device changing independently from the pitch of the road due to suspension movement, which I found was significant and annoyingly difficult to account for when trying to use pitch to calculate desired engine torque output for the RAM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ toyota
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants