enhance CANPacker with efficient MessageData struct #1440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a more efficient MessageData struct in the CANPacker class to significantly reduce map lookup overhead during CAN message packing. The original code performed excessive lookups, including inefficient searches using std::pair<address, string> keys. For example, the following code snippet includes five separate map lookups:
By optimizing the way signals, counters, and checksums are accessed, the new structure improves performance and simplifies the code.
Key improvements:
These enhancements lead to faster CAN message packing, particularly for larger datasets and frequent updates.