Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexus: prevent lagged gas after heavy braking #1266

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Sep 24, 2024

If you switch from a high negative aceleration request to a positive one, sometimes the gas has to "unwind" from the negative acceleration value. Which doesn't make sense, but is what happens.

If you rate limit your request or send zero for one frame, then it is fine and the gas starts from 0 immediately.

@github-actions github-actions bot added car related to opendbc/car/ toyota labels Sep 24, 2024
@sshane sshane merged commit f2c4bb7 into master Sep 24, 2024
3 checks passed
@sshane sshane deleted the lexus-prevent-gas-lag branch September 24, 2024 03:56
sshane added a commit that referenced this pull request Sep 24, 2024
sshane added a commit that referenced this pull request Sep 24, 2024
Revert "Lexus: prevent lagged gas after heavy braking (#1266)"

This reverts commit f2c4bb7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ toyota
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant