Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: enable new long tune for Corolla TSS2 #1259

Closed
wants to merge 1 commit into from

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Sep 20, 2024

High speed is largely unaffected, but low speed reaches the target acceleration faster.

master Corolla route: a2bddce0b6747e10/0000025b--a32628ab6b

PCM comp Corolla route: a2bddce0b6747e10/0000025a--bd4dcd6aec

Summary:

master
Summary
start from stop
Target crossed 4 out of 4 runs

Mean time to cross: 3.663s, min: 3.251s, max: 4.153s

creep: alternate between +1m/s^2 and -1m/s^2
Target crossed 2 out of 2 runs

Mean time to cross: 2.553s, min: 2.399s, max: 2.707s

brake step response: -1m/s^2 from 20mph
Target crossed 3 out of 3 runs

Mean time to cross: 1.066s, min: 0.901s, max: 1.198s

brake step response: -4m/s^2 from 20mph
Target crossed 3 out of 3 runs

Mean time to cross: 2.132s, min: 2.099s, max: 2.149s

gas step response: +1m/s^2 from 20mph
Target crossed 3 out of 3 runs

Mean time to cross: 0.933s, min: 0.750s, max: 1.151s

gas step response: +4m/s^2 from 20mph
Target crossed 0 out of 3 runs
PCM compensation
Summary
start from stop
Target crossed 4 out of 4 runs

Mean time to cross: 2.513s, min: 1.802s, max: 2.900s

creep: alternate between +1m/s^2 and -1m/s^2
Target crossed 2 out of 2 runs

Mean time to cross: 1.925s, min: 1.901s, max: 1.950s

brake step response: -1m/s^2 from 20mph
Target crossed 3 out of 3 runs

Mean time to cross: 1.066s, min: 1.000s, max: 1.100s

brake step response: -4m/s^2 from 20mph
Target crossed 3 out of 3 runs

Mean time to cross: 2.102s, min: 2.051s, max: 2.154s

gas step response: +1m/s^2 from 20mph
Target crossed 3 out of 3 runs

Mean time to cross: 0.900s, min: 0.702s, max: 1.249s

gas step response: +4m/s^2 from 20mph
Target crossed 0 out of 3 runs

Some plots:

Left is master, right is this branch:

image

image

image

@github-actions github-actions bot added car related to opendbc/car/ toyota labels Sep 20, 2024
@sshane
Copy link
Contributor Author

sshane commented Oct 4, 2024

will just merge when we're ready

@sshane sshane closed this Oct 4, 2024
@sshane sshane deleted the new-toyota-tune-corolla branch October 4, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ toyota
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant