parser: refactor value dictionary update logic #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some unit tests to enforce this behavior? |
|
made a few modifications to the test case. It should be able to catch these issues now. |
deanlee
force-pushed
the
parser_refactor_update
branch
from
7604621
to
071b620
Compare
deanlee
force-pushed
the
parser_refactor_update
branch
2 times, most recently
from
f9f194f
to
441750e
Compare
update test case improve update()
deanlee
force-pushed
the
parser_refactor_update
branch
from
441750e
to
105f429
Compare
|
merged to #1046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes:
SignalValuestruct and thequery_latest()function. These were previously used to copy updated values to Cython code and initializing the value dictionary in Cython's__init__method when query_latest() was called with empty CAN strings.MessageStateto Cython code, enabling direct access to values fromMessageStateafter an update.current_nanos.These changes significantly simplify the update logic, improve performance, and eliminate issues related to the problematic
last_nanosandcurrent_nanosin query_latest(). This refactor fixes multiple issues, including:Remaining Tasks for Issue 1066 (will be resolved in another PR):
- Ensure the
valsin MessageState are always the newest.- Ensure
all_valsare sorted by received time.