Tesla: Move DI_speed to correct bus and update signals within #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carleeno
changed the title
carleeno
force-pushed
the
update-di-speed
branch
from
32309b9
to
cea4659
Compare
|
The message is on both buses. i wouldn't change anything here. |
|
not needed after all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the DI_speed message definition to the correct bus and updates the signals within to match the actual canbus data from model 3/Y
DI_speed doesn't exist on the party bus (at least not at 599).
At the moment nothing uses DI_speed so it wasn't discovered that it wasn't present on party bus. As such this change is a no-op to OP behavior on Tesla, but enables a future improvement to use uiSpeed for vEgoCluster
verification: bbbf82d987d681bc/000001cc--b24bcec625/0