-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group node fixes #2259
Group node fixes #2259
Conversation
I tested this and confirm that it now fails properly when there's a missing connection. There's no popup about failed validation (which makes this somewhat easy to miss), but that sometimes happens with "normal" nodes as well. |
Ah, I think the issue is that the popup only pops up if all paths to all outputs are invalid. I tend to have random preview images in the middle, so if I break something beyond that it's not going to jump at me to complain. But that's unrelated to group nodes in particular. |
* Prevent cleaning graph state on undo/redo * Remove pause rendering due to LG bug * Fix crash on disconnected internal reroutes * Fix widget inputs being incorrect order and value * Fix initial primitive values on connect * basic support for basic rerouted converted inputs * Populate primitive to reroute input * dont crash on bad primitive links * Fix convert to group changing control value * reduce restrictions * fix random crash in tests
Fixes 3 issues:
Fix crash on unlinked grouped reroute
group_unlinked_reroute.json - Disconnect image link between the two group nodes, click queue
Fix converted widget inputs
group_widget_inputs.json - Convert two KSamplers to a group node
Add basic support for reroute inputs connected to converted widget inputs
reroute_converted_input.json - Convert reroute + latent node to group