Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group node fixes #2259

Merged
merged 12 commits into from
Dec 13, 2023
Merged

Conversation

pythongosssss
Copy link
Contributor

Fixes 3 issues:

  1. Fix crash on unlinked grouped reroute
    group_unlinked_reroute.json - Disconnect image link between the two group nodes, click queue

    • Before: Crashes on queue
    • After: Shows missing input error
  2. Fix converted widget inputs
    group_widget_inputs.json - Convert two KSamplers to a group node

    • Before: Various issues - links disconnected, value lost, fixing the links and queuing gets links incorrect (Return type mismatch between linked nodes)
    • After: Works
  3. Add basic support for reroute inputs connected to converted widget inputs
    reroute_converted_input.json - Convert reroute + latent node to group

    • Before: Unsupported, would add a INT widget to the group that does nothing
    • After: Works for reroutes connected directly to inputs, not via chains. I didn't want to have to basically duplicate the walking reroute path and want to refactor that out in future.

@Simn
Copy link

Simn commented Dec 12, 2023

I tested this and confirm that it now fails properly when there's a missing connection. There's no popup about failed validation (which makes this somewhat easy to miss), but that sometimes happens with "normal" nodes as well.

@pythongosssss
Copy link
Contributor Author

You're not seeing this when clicking queue?
image

@Simn
Copy link

Simn commented Dec 12, 2023

Ah, I think the issue is that the popup only pops up if all paths to all outputs are invalid. I tend to have random preview images in the middle, so if I break something beyond that it's not going to jump at me to complain. But that's unrelated to group nodes in particular.

@comfyanonymous comfyanonymous merged commit 3900789 into comfyanonymous:master Dec 13, 2023
1 check passed
@pythongosssss pythongosssss deleted the group-fixes branch December 17, 2023 17:51
HorusElohim pushed a commit to HorusElohim/PyfyUI that referenced this pull request Feb 17, 2024
* Prevent cleaning graph state on undo/redo

* Remove pause rendering due to LG bug

* Fix crash on disconnected internal reroutes

* Fix widget inputs being incorrect order and value

* Fix initial primitive values on connect

* basic support for basic rerouted converted inputs

* Populate primitive to reroute input

* dont crash on bad primitive links

* Fix convert to group changing control value

* reduce restrictions

* fix random crash in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants