Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: Mask Editor #2171

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

ltdrdata
Copy link
Collaborator

@ltdrdata ltdrdata commented Dec 4, 2023

improved:

  1. Basic structure improvement
  2. Enhance to display the image in the center of the dialog.
  3. Zoom feature: ctrl + wheel
  4. Pan feature: ctrl + left button drag

fixed:
Fix the issue where the existing mask does not appear when loading an image with a mask.

@ShmuelRonen
Copy link

ShmuelRonen commented Dec 5, 2023

fixed:
Fix the issue where the existing mask does not appear when loading an image with a mask.

Is not fixed for me!! the second time that I open the mask editor, the mask disappear!

mask.mp4

@ltdrdata
Copy link
Collaborator Author

ltdrdata commented Dec 6, 2023

fixed: Fix the issue where the existing mask does not appear when loading an image with a mask.

Is not fixed for me!! the second time that I open the mask editor, the mask disappear!

mask.mp4

What is your browser?

Do the zoom and pan functions work with ctrl-wheel and ctrl-drag, properly?

@ShmuelRonen
Copy link

ShmuelRonen commented Dec 6, 2023

fixed: Fix the issue where the existing mask does not appear when loading an image with a mask.
Is not fixed for me!! the second time that I open the mask editor, the mask disappear!
mask.mp4

What is your browser?

Do the zoom and pan functions work with ctrl-wheel and ctrl-drag, properly?

  1. I use the Brave browser for a long time (chrome engine).
  2. The zoom function with Crtl and mouse weel works 4 me. but strangely it impact the main screen to enlarge or reduce simultainly...

@comfyanonymous comfyanonymous merged commit 8112a0d into comfyanonymous:master Dec 6, 2023
1 check passed
@ltdrdata
Copy link
Collaborator Author

ltdrdata commented Dec 6, 2023

fixed: Fix the issue where the existing mask does not appear when loading an image with a mask.
Is not fixed for me!! the second time that I open the mask editor, the mask disappear!
mask.mp4

What is your browser?
Do the zoom and pan functions work with ctrl-wheel and ctrl-drag, properly?

  1. I use the Brave browser for a long time (chrome engine).
  2. The zoom function with Crtl and mouse weel works 4 me. but strangely it impact the main screen to enlarge or reduce simultainly...

Unfortunately, Browser is not the problem. I have no issue on Brave browser.
There is a possibility of custom nodes problem.

In my experience, using front-end extensions that manipulate styles, such as ricing, has led to layout issues.

Try testing it once by disabling all custom_nodes and removing all extensions from web/extensions, except the web/extensions/core.

@ShmuelRonen
Copy link

ShmuelRonen commented Dec 6, 2023

fixed: Fix the issue where the existing mask does not appear when loading an image with a mask.
Is not fixed for me!! the second time that I open the mask editor, the mask disappear!
mask.mp4

What is your browser?
Do the zoom and pan functions work with ctrl-wheel and ctrl-drag, properly?

  1. I use the Brave browser for a long time (chrome engine).
  2. The zoom function with Crtl and mouse weel works 4 me. but strangely it impact the main screen to enlarge or reduce simultainly...

Unfortunately, Browser is not the problem. I have no issue on Brave browser. There is a possibility of custom nodes problem.

In my experience, using front-end extensions that manipulate styles, such as ricing, has led to layout issues.

Try testing it once by disabling all custom_nodes and removing all extensions from web/extensions, except the web/extensions/core.

I made another test that show that after screen refresh, the mask come back. but not a practical solution...

redray.mp4

@ltdrdata
Copy link
Collaborator Author

ltdrdata commented Dec 6, 2023

fixed: Fix the issue where the existing mask does not appear when loading an image with a mask.
Is not fixed for me!! the second time that I open the mask editor, the mask disappear!
mask.mp4

What is your browser?
Do the zoom and pan functions work with ctrl-wheel and ctrl-drag, properly?

  1. I use the Brave browser for a long time (chrome engine).
  2. The zoom function with Crtl and mouse weel works 4 me. but strangely it impact the main screen to enlarge or reduce simultainly...

Unfortunately, Browser is not the problem. I have no issue on Brave browser. There is a possibility of custom nodes problem.
In my experience, using front-end extensions that manipulate styles, such as ricing, has led to layout issues.
Try testing it once by disabling all custom_nodes and removing all extensions from web/extensions, except the web/extensions/core.

I made another test that show that after screen refresh, the mask come back. but not a practical solution...

redray.mp4

Your mask editor appears to be an older version that has not incorporated the PR. The current PR has been merged to the latest version of ComfyUI, so update ComfyUI and check it again.

@ShmuelRonen
Copy link

Thanks! it works for me. Perfect!!!

@ShmuelRonen
Copy link

ShmuelRonen commented Dec 6, 2023

Another thing. When I zoom in a image in mask editor, I can't move it up or down Like in photoshop but stuck in the middle of the frame. there is a solution?

@ltdrdata
Copy link
Collaborator Author

ltdrdata commented Dec 6, 2023

Another thing. When I zoom in a image in mask editor, I can't move it up or down Like in photoshop but stuck in the middle of the frame. there is a solution?

drag canvas with ctrl key.

@ltdrdata ltdrdata deleted the improve/maskeditor branch December 6, 2023 15:31
HorusElohim pushed a commit to HorusElohim/PyfyUI that referenced this pull request Feb 17, 2024
* renewal mask editor

* fix: ignoring keydown when 2nd open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants