-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Load controlnet in fp8 if weights are in fp8.
- Loading branch information
1 parent
2d810b0
commit dc96a1a
Showing
3 changed files
with
33 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc96a1a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean load ControlNet in FP8 automatically, if Flux is loaded FP8 ?
What about GGUF models ?
People using Q4 may want ControlNet in FP8, but if you use Q8_0, you may want the full quality ControlNet model.
Why not add an option to load ControlNet in FP8, in an "advanced" ControlNet loader node ?
dc96a1a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This loads the controlnet in fp8 if the controlnet weights are in fp8.
dc96a1a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks, this makes more sense.
But do you know any ControlNet models in FP8 ?
Maybe you could convert some of the larger ones.
Do you think ControlNet in Q8_0 could work too ?
dc96a1a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's done, already :
https://huggingface.co/Kijai/flux-fp8/blob/main/flux_shakker_labs_union_pro-fp8_e4m3fn.safetensors