Make empty arrays and dictionaries render compactly even when indent > 0 #501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #499
We take a similar strategy as we do for adding commas: rather than calling
renderIndent
immediately after opening a new array/dict and atvisitEnd
, we instead set anindentBuffered
flag and defer therenderIndent
until later. Then eachflushBuffer
call can render the indent where necessary, andvisitEnd
can perform some additional checks that the collection is not empty before rendering the final indentAdded some basic tests to
ExampleTests.scala
, since some of this behavior is probably worth showing to users in the documentation