Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BSP target capabilities #3575

Conversation

AnthonyGrod
Copy link
Contributor

@AnthonyGrod AnthonyGrod commented Sep 18, 2024

Context: I'm working on integrating Mill over the new BSP plugin (I created a pull request with more detail a few weeks ago here: #3432)

I encountered an issue where there were to many options of actions that could be performed on a certain testing module. Namely, there was a redundant run capability. On the first screenshot there is the option menu before my changes and on the second after them.

The visual aspect of this fix is nice but not the most important one. Without this fix, the testing via BSP does not work at all - the BSP plugin, even after triggering the Test button, launches Run action instead of the Test action if the module's canRun capability is set to true.

image image

@lefou
Copy link
Member

lefou commented Sep 18, 2024

Since TestModules are also RunModules, it's legit to run a main class without any test framework. Therefore I doubt simply disabling the run capability is the correct solution: Looks like a workaround fro some other underlying issue to me.

@lihaoyi lihaoyi closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants