MNT Fix scss lint warnings (#289)

colymba · Jun 11, 2024 · 0fd4d5a · 0fd4d5a
1 parent e6b27ac
commit 0fd4d5a
Show file tree

Hide file tree

Showing 8 changed files with 439 additions and 887 deletions.
diff --git a/.stylelintignore b/.stylelintignore
diff --git a/client/dist/styles/main.css b/client/dist/styles/main.css
diff --git a/client/src/styles/bundle.scss b/client/src/styles/bundle.scss
@@ -1,6 +1,5 @@
 // Variables (from silverstripe/admin)
 @import "variables";
-
 @import "./manager";
 @import "./managerBulkEditingForm";
 @import "./uploader";
diff --git a/client/src/styles/manager.scss b/client/src/styles/manager.scss
@@ -55,6 +55,7 @@
           min-width: 120px;
         }
 
+        /* stylelint-disable-next-line selector-max-compound-selectors */
         .chosen-container-single .chosen-single
         {
           border-top-right-radius: 0;
@@ -67,7 +68,6 @@
         float: left;
         border-top-left-radius: 0;
         border-bottom-left-radius: 0;
-
         height: 36px;
         line-height: 26px;
         margin-left: -1px;
@@ -91,13 +91,10 @@
         float: left;
         clear: none;
         max-width: 100%;
-
         margin: 0;
         padding: 0 1.25rem;
-
         height: 36px;
         line-height: 34px;
-
         opacity: 0;
         overflow: auto;
 
@@ -111,10 +108,6 @@
           opacity: 1;
         }
       }
-
-      .bulkSelectAll
-      {
-      }
     }
   }// .bulkManagerOptions
 

diff --git a/client/src/styles/managerBulkEditingForm.scss b/client/src/styles/managerBulkEditingForm.scss
@@ -3,9 +3,7 @@
 {
 	float: left;
 	width: 70%;
-
-	margin: 40px 0 20px 0;
-
+	margin: 40px 0 20px;
 	font-size: 30px;
 	font-weight: bold;
 }
@@ -15,9 +13,7 @@
 	float: right;
 	clear: right;
 	width: 25%;
-
-	margin: 40px 0 20px 0;
-
+	margin: 40px 0 20px;
 	text-decoration: underline;
 	text-align: right;
 	cursor: pointer;
@@ -32,13 +28,7 @@
 	&.hasUpdate .ui-accordion-header
 	{
 		background-color: #f2ba11;
-
-		background-image: -webkit-gradient(linear, 50% 0%, 50% 100%, color-stop(0%, #f2ba11), color-stop(100%, #df6e00));
-		background-image: -webkit-linear-gradient(top, #f2ba11 0%, #df6e00 100%);
-		background-image: -moz-linear-gradient(top, #f2ba11 0%, #df6e00 100%);
-		background-image: -o-linear-gradient(top, #f2ba11 0%, #df6e00 100%);
-		background-image: -ms-linear-gradient(top, #f2ba11 0%, #df6e00 100%);
-		background-image: linear-gradient(top, #f2ba11 0%, #df6e00 100%);
+		background-image: linear-gradient(to top, #f2ba11 0%, #df6e00 100%);
 
 		a
 		{
@@ -50,18 +40,12 @@
 	&.updated .ui-accordion-header
 	{
 		background-color: #a4ca3a;
-
-		background-image: -webkit-gradient(linear, 50% 0%, 50% 100%, color-stop(0%, #a4ca3a), color-stop(100%, #59781D));
-		background-image: -webkit-linear-gradient(top, #a4ca3a 0%, #59781D 100%);
-		background-image: -moz-linear-gradient(top, #a4ca3a 0%, #59781D 100%);
-		background-image: -o-linear-gradient(top, #a4ca3a 0%, #59781D 100%);
-		background-image: -ms-linear-gradient(top, #a4ca3a 0%, #59781D 100%);
-		background-image: linear-gradient(top, #a4ca3a 0%, #59781D 100%);
+		background-image: linear-gradient(to top, #a4ca3a 0%, #59781D 100%);
 
 		a
 		{
 			color: #fff;
 			text-shadow: none;
 		}
 	}
-}
+}
diff --git a/client/src/styles/uploader.scss b/client/src/styles/uploader.scss
@@ -2,7 +2,7 @@
 {
 	.uploadfield__droptext
 	{
-		&::before
+		&:before
 		{
 			text-transform: none;
 			content: "b";

diff --git a/package.json b/package.json
@@ -10,10 +10,10 @@
     "watch": "NODE_ENV=development webpack --watch --progress",
     "css": "WEBPACK_CHILD=css npm run build",
     "tx": "tx push --source && tx pull --all && node transifex.js",
-    "lint": "eslint client/src && yarn lint-sass",
+    "lint": "yarn lint-js && yarn lint-sass",
     "lint-js": "eslint client/src",
     "lint-js-fix": "eslint client/src --fix",
-    "lint-sass": "stylelint **/client/src/**/*.scss"
+    "lint-sass": "stylelint client/src"
   },
   "repository": {
     "type": "git",