refactoring

colorer · Sep 15, 2024 · ab3b93a · ab3b93a
1 parent 2f30d60
commit ab3b93a
Show file tree

Hide file tree

Showing 5 changed files with 75 additions and 72 deletions.
diff --git a/src/colorer/parsers/CatalogParser.cpp b/src/colorer/parsers/CatalogParser.cpp
@@ -9,7 +9,7 @@ void CatalogParser::parse(const UnicodeString* path)
   hrc_locations.clear();
   hrd_nodes.clear();
 
-  XmlInputSource catalogXIS(*path);
+  const XmlInputSource catalogXIS(*path);
   XmlReader xml(catalogXIS);
   if (!xml.parse()) {
     throw CatalogParserException(*path + UnicodeString(" parse error"));
@@ -94,7 +94,7 @@ std::unique_ptr<HrdNode> CatalogParser::parseHRDSetsChild(const XMLNode& elem)
       if (!attr_value.isEmpty()) {
         hrd_node->hrd_location.emplace_back(attr_value);
         COLORER_LOG_DEBUG("add hrd location '%' for %:%", hrd_node->hrd_location.back(), hrd_node->hrd_class,
-                      hrd_node->hrd_name);
+                          hrd_node->hrd_name);
       }
       else {
         COLORER_LOG_WARN("found hrd with empty location. skip it location.");

diff --git a/src/colorer/parsers/CatalogParser.h b/src/colorer/parsers/CatalogParser.h
@@ -31,7 +31,7 @@ class CatalogParser
   void parseHrdSetsBlock(const XMLNode& elem);
 };
 
-class CatalogParserException : public Exception
+class CatalogParserException final : public Exception
 {
  public:
   explicit CatalogParserException(const UnicodeString& msg) noexcept : Exception("[CatalogParserException] " + msg) {}