forked from tobi/delayed_job
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forking Launcher #1138
Open
johnnyshields
wants to merge
21
commits into
collectiveidea:master
Choose a base branch
from
johnnyshields:forking-launcher
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Forking Launcher #1138
johnnyshields
wants to merge
21
commits into
collectiveidea:master
from
johnnyshields:forking-launcher
Commits on Apr 4, 2021
-
Adds support for running as a forking process in the foreground
Reason: The `script/delayed_job` process (described above) uses the [Daemons](https://github.com/thuehlinger/daemons) gem which has several undesirable behaviors when running inside a container (Docker, etc.): - The parent process spawns a background child process then exits immediately, which causes the container to shutdown. - The worker processes are detached from the parent, which prevents logging to `STDOUT`. The `--fork` option solves this by running workers in a foreground process tree. When using `--fork` the `daemons` gem is not required. The command script requires changing the following line to enable this: # always daemonizes, never forks Delayed::Command.new(ARGV).daemonize must now be: # daemonize by default unless --fork specified Delayed::Command.new(ARGV).launch In addition, there are several quality of life improvements added to the Command script: - Command: Add --pools arg as an alias for --pool, and allow pipe-delimited pool definitions - Command: Add --num-worker arg as an alias for -n / --number-of-workers (and deprecate --number-of-workers) - Command: Pool parsing code has been extracted to PoolParser class - Command: Add -v / --verbose switch which sets quiet=false on workers - Command: Add -x switch as alias for --exit-on-complete - Command: Add STDERR warning num-workers less than 1 - Command: Add STDERR warning if num-workers and pools both specified (pools overrides num-workers as per existing behavior) - Command: Add STDERR warning if queues and pools both specified (pools overrides num-workers as per existing behavior) The Rake script has also been enhanced: - Rake: Uses Forking launcher under the hood - Rake: Add support for NUM_WORKERS and POOLS args
Configuration menu - View commit details
-
Copy full SHA for 54eba86 - Browse repository at this point
Copy the full SHA 54eba86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3401c24 - Browse repository at this point
Copy the full SHA 3401c24View commit details
Commits on Apr 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d328cb8 - Browse repository at this point
Copy the full SHA d328cb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd0db79 - Browse repository at this point
Copy the full SHA dd0db79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40d9f04 - Browse repository at this point
Copy the full SHA 40d9f04View commit details -
- Add validation of min vs. max priority
Configuration menu - View commit details
-
Copy full SHA for 0a7145f - Browse repository at this point
Copy the full SHA 0a7145fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d0d3fe - Browse repository at this point
Copy the full SHA 9d0d3feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 246936c - Browse repository at this point
Copy the full SHA 246936cView commit details
Commits on Apr 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ea83992 - Browse repository at this point
Copy the full SHA ea83992View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c87350 - Browse repository at this point
Copy the full SHA 2c87350View commit details -
Configuration menu - View commit details
-
Copy full SHA for 853efa9 - Browse repository at this point
Copy the full SHA 853efa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed855a4 - Browse repository at this point
Copy the full SHA ed855a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 226d6d8 - Browse repository at this point
Copy the full SHA 226d6d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f284da - Browse repository at this point
Copy the full SHA 7f284daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f225da - Browse repository at this point
Copy the full SHA 6f225daView commit details -
Configuration menu - View commit details
-
Copy full SHA for a17c488 - Browse repository at this point
Copy the full SHA a17c488View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d06a33 - Browse repository at this point
Copy the full SHA 0d06a33View commit details
Commits on Apr 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 293522b - Browse repository at this point
Copy the full SHA 293522bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60ccd9a - Browse repository at this point
Copy the full SHA 60ccd9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ab0d17 - Browse repository at this point
Copy the full SHA 6ab0d17View commit details
Commits on Apr 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dfa5561 - Browse repository at this point
Copy the full SHA dfa5561View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.