Prevent wildcard expressions for stopwords in simple expressions #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reebalazs
force-pushed
the
ree-fix-stopwords-with-wildcards
branch
3 times, most recently
from
84bcb30
to
568da9a
Compare
reebalazs
changed the title
- add stopwords to registry - add stopwords_case_insensitive option - support function for getting the stopwords - cache to optimize the parsing of stopwords.txt This transforms the (term AND term*) expression for stopwords, removing the wildcard expression. Such an expression would never match any documents, because solr won't remove the wildcard term, but the stopword will be missing from the index. This workaround does that with no side effects, as stopwords would be ignored by solr anyway. Both case sensitive and case insensitive stopword processing is supported, this depends on the solr schema, and must be set accordingly.
reebalazs
force-pushed
the
ree-fix-stopwords-with-wildcards
branch
from
568da9a
to
097a3bf
Compare
tisto
approved these changes
Jan 23, 2024
|
@reebalazs released with c.solr. 9.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transforms the (term AND term*) expression for stopwords, removing the wildcard expression. Such an expression would never match any documents, because solr won't remove the wildcard term, but the stopword will be missing from the index. This workaround does that with no side effects, as stopwords would be ignored by solr anyway.