Hyde resp - mobile navigation #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ince they are not really needed anyway and somtimes produce strange artifacts. Reduce the padding of these classes from 5 to 4%. Add styles for the relative links.
…mments for readability and hopefully clarity.
|
@novalix Thanks for doing this work. Nice to see our themes get a little styling attention. :) I'm happy to merge this if I can demo the results once your site is deployed. Is it up yet? |
|
I just tested this out a bit. It looks like it's a bit messed up, at least when I served up the files locally. Testing with Chromium on Ubuntu 18.04 with dev tools for mobile. Merged PR in with latest master. Current version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this code wraps the site links of the header bar in an off the scene container on smaller devices. Instead a Hamburger Icon is displayed which toggles the menu visible.
It 's built without any script involved only a little CSS-Trickery.
I have tested it in different browsers and simulators on the desktop but not on any real device. So there is still a quantum of possible fuck-up.
I am in the process of setting up my new site with coleslaw and intend to use that code so it can be seen in "action".
Groetjes, niels