RANGER-4314: Delete nonexistent user return error status code

coldestlin · Jul 13, 2023 · 67deb82 · 67deb82
1 parent 593d15a
commit 67deb82
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java b/security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java
@@ -2249,10 +2249,10 @@ public synchronized void deleteXUser(Long id, boolean force) {
 		xaBizUtil.blockAuditorRoleUser();
 		XXUserDao xXUserDao = daoManager.getXXUser();
 		XXUser xXUser =	xXUserDao.getById(id);
-		VXUser vXUser =	xUserService.populateViewBean(xXUser);
-		if(vXUser==null || StringUtils.isEmpty(vXUser.getName())){
+		if(xXUser==null || StringUtils.isEmpty(xXUser.getName())){
 			throw restErrorUtil.createRESTException("No user found with id=" + id);
 		}
+		VXUser vXUser =	xUserService.populateViewBean(xXUser);
 		XXPortalUserDao xXPortalUserDao=daoManager.getXXPortalUser();
 		XXPortalUser xXPortalUser=xXPortalUserDao.findByLoginId(vXUser.getName().trim());
 		VXPortalUser vXPortalUser=null;