-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update linking related variable name and replace some binarySearch #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a commit to completely eliminate sizeLinkVars since it doesn't even make sense anymore. It was tracking the size of the vector of indices of the linking variable, but now varType_
always has size equal to the total number of variables.
break; | ||
} | ||
} | ||
} | ||
|
||
for(i = 0; i < lCols; i++){ | ||
index = lColIndices[i]; | ||
varType_[i] = MibSVarLower; | ||
varType_[index] = MibSVarLower; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this!
Is this still a draft? |
Update:
Tested on both general and interdiction instances. |
sizeFixedInd
tosizeLinkVars
to match a earlier name change.MibSModel
, move the "check linking variables are integers" block fromreadProblemData()
toanalyzeStructure()
; it also fix a bug on indices.