Skip to content

Commit

Permalink
More unifying names (no Homogeneous, only Heterogeneous)
Browse files Browse the repository at this point in the history
  • Loading branch information
dlesbre committed Apr 16, 2024
1 parent 229e1ab commit dedd568
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
12 changes: 6 additions & 6 deletions patriciaTree.ml
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ module WeakSetNode(Key:sig type 'a t end)(* :Node *) = struct

end

module MakeCustom
module MakeCustomHeterogeneous
(Key:HeterogeneousKey)
(Value:Value)
(Node:Node with type 'a key = 'a Key.t and type ('key,'map) value = ('key,'map) Value.t) :
Expand Down Expand Up @@ -1389,7 +1389,7 @@ end
module MakeHeterogeneousSet(Key:HeterogeneousKey) : HeterogeneousSet_S
with type 'a elt = 'a Key.t = struct
module Node = SetNode(Key)
module BaseMap = MakeCustom(Key)(struct type ('a,'b) t = unit end)(Node)
module BaseMap = MakeCustomHeterogeneous(Key)(struct type ('a,'b) t = unit end)(Node)

(* No need to differentiate the values. *)
include BaseMap
Expand Down Expand Up @@ -1456,7 +1456,7 @@ module MakeHeterogeneousSet(Key:HeterogeneousKey) : HeterogeneousSet_S
end

module MakeHeterogeneousMap(Key:HeterogeneousKey)(Value:Value) =
MakeCustom(Key)(Value)(SimpleNode(Key)(Value))
MakeCustomHeterogeneous(Key)(Value)(SimpleNode(Key)(Value))



Expand Down Expand Up @@ -1486,14 +1486,14 @@ module HeterogeneousKeyFromKey(Key:Key):(HeterogeneousKey with type 'a t = Key.t
let to_int = Key.to_int
end

module MakeCustomHomogeneous
module MakeCustom
(Key:Key)
(Node:Node with type 'a key = Key.t and type ('key,'map) value = ('key,'map) snd)
= struct

module NewKey(* :Key *) = HeterogeneousKeyFromKey(Key)

module BaseMap = MakeCustom(NewKey)(WrappedHomogeneousValue)(Node)
module BaseMap = MakeCustomHeterogeneous(NewKey)(WrappedHomogeneousValue)(Node)
include BaseMap
type key = Key.t

Expand Down Expand Up @@ -1592,7 +1592,7 @@ end
module MakeMap(Key:Key) = struct
module NKey = struct type 'a t = Key.t end
module Node = SimpleNode(NKey)(WrappedHomogeneousValue)
include MakeCustomHomogeneous(Key)(Node)
include MakeCustom(Key)(Node)
end

module MakeSet(Key : Key) : Set_S with type elt = Key.t = struct
Expand Down
4 changes: 2 additions & 2 deletions patriciaTree.mli
Original file line number Diff line number Diff line change
Expand Up @@ -890,15 +890,15 @@ module MakeHeterogeneousMap(Key:HeterogeneousKey)(Value:Value):HeterogeneousMap_
disk, lazy evaluation and/or caching, etc. *)

(** Create a Homogeneous Map with a custom {!Node}. *)
module MakeCustomHomogeneous
module MakeCustom
(Key:Key)
(Node:Node with type 'a key = Key.t and type ('key,'map) value = ('key,'map) snd)
:Map_S
with type key = Key.t
and type 'm t = 'm Node.t

(** Create an Heterogeneous map with a custom {!Node}. *)
module MakeCustom
module MakeCustomHeterogeneous
(Key:HeterogeneousKey)
(Value:Value)
(Node:Node with type 'a key = 'a Key.t and type ('key,'map) value = ('key,'map) Value.t)
Expand Down
6 changes: 3 additions & 3 deletions patriciaTreeTest.ml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ let%test_module "TestHeterogeneous" = (module struct
end


module Map = MakeCustom(MyKey)(MyValue)(SimpleNode(MyKey)(MyValue))
module Map = MakeCustomHeterogeneous(MyKey)(MyValue)(SimpleNode(MyKey)(MyValue))
open Map

let _m1 = singleton (MyKey.Int 7) (MyValue.AString "seven")
Expand Down Expand Up @@ -108,7 +108,7 @@ let%test_module "TestHeterogeneous" = (module struct
| _ -> NBranch{prefix;branching_bit;tree0;tree1}
end

module Map2 = MakeCustom(MyKey)(MyValue)(SimpleNode(MyKey)(MyValue))
module Map2 = MakeCustomHeterogeneous(MyKey)(MyValue)(SimpleNode(MyKey)(MyValue))
open Map2

let _m1 = singleton (MyKey.Int 7) (MyValue.AString "seven")
Expand Down Expand Up @@ -500,7 +500,7 @@ let%test_module "TestWeak" = (module struct
end

module Node = WeakNode(struct type 'a t = MyKey.t end)(WrappedHomogeneousValue)
module Map = MakeCustomHomogeneous(MyKey)(Node)
module Map = MakeCustom(MyKey)(Node)
open Map

let _m1 = singleton (MyKey.Block 7) "seven"
Expand Down

0 comments on commit dedd568

Please sign in to comment.