-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for new member webhook config names #950
Changes from 20 commits
8c75a65
713935c
acc9cad
839d115
70228f0
5a746f0
5dc10ef
7e60732
9e8562a
606b57d
511d46a
ca707de
e81f331
079d985
ef2985c
eb0da7b
efd4951
f85014c
ac49620
feedeba
df593ee
3562751
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -289,7 +289,7 @@ get-and-publish-operators: clean-e2e-files get-and-publish-host-operator get-and | |
# The reason is that when the host operator is installed, then the logic creates ToolchainConfig CR which | ||
# defines that the webhook should be deployed from the first member instance (and not from the second one). | ||
# This is important to set before the member operators are installed, otherwise, it can lead to flaky e2e tests. | ||
get-publish-install-and-register-operators: get-and-publish-host-operator setup-toolchainclusters create-host-resources get-and-publish-member-operator | ||
get-publish-install-and-register-operators: get-and-publish-host-operator get-and-publish-member-operator setup-toolchainclusters create-host-resources | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is needed since now we are deploying the toolchaincluster-member SA from the member-operator deployment, thus we need to run In order to invert those make targets I had todo some changes in member operator, see paired PR for those. |
||
|
||
.PHONY: get-publish-and-install-operators | ||
# IMPORTANT: The host operator needs to be installed first. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminder