-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the migration step to kubeconfig #426
Remove the migration step to kubeconfig #426
Conversation
for the legacy fields in ToolchainCluster.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 78.57% 77.35% -1.23%
==========================================
Files 49 49
Lines 2054 2009 -45
==========================================
- Hits 1614 1554 -60
- Misses 379 401 +22
+ Partials 61 54 -7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I have left only few minor comments.
controllers/toolchaincluster/toolchaincluster_controller_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side, but please address @mfrancisc's comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good .
Just a Minor question
(some of) the future surprises.
Quality Gate passedIssues Measures |
Remove the migration step to kubeconfig and update the tests to not test for the legacy fields in ToolchainCluster.
This a follow-up of #412 that updates the testsuite to not rely on the legacy fields that defined the connection settings for the clusters.
This is safe to do, because all of our clusters have already been upgraded and have the kubeconfigs generated in the connection secrets.
Related PRs: