Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify social event support in internal landing page #456

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

alexeykazakov
Copy link
Contributor

This PR introduces a few changes to the internal landing page to better support social events:

  1. Removes the ToS checkbox. ToS are enforced via SSO anyway. We don't need it here.
  2. Add OpenShift AI card and update the card descriptions (the Dev Spaces card is still hidden):
    dashboard
  3. Hide the token claims & proxy login info under a collapsible +:
    dashboard
  4. If the verification is required then hide the phone verification field and show the Activation Code field only:
    activation_code

Copy link

sonarcloud bot commented Aug 30, 2024

Copy link

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, sbryzak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,sbryzak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (5faca3a) to head (43c4c3c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files          42       42           
  Lines        2742     2742           
=======================================
  Hits         2159     2159           
  Misses        490      490           
  Partials       93       93           
Flag Coverage Δ
unittests 78.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xcoulon
Copy link
Contributor

xcoulon commented Aug 30, 2024

4. If the verification is required then hide the phone verification field and show the Activation Code field only:

I'm curious, how can we make sure that all hackathon users will have verification required (so they have a chance to input the Activation Code)

@alexeykazakov alexeykazakov merged commit ada25da into codeready-toolchain:master Aug 30, 2024
10 of 11 checks passed
@alexeykazakov alexeykazakov deleted the landingpage branch August 30, 2024 18:39
@rajivnathan
Copy link
Contributor

I'm curious, how can we make sure that all hackathon users will have verification required (so they have a chance to input the Activation Code)

@xcoulon I think Matous explained it here: https://redhat-internal.slack.com/archives/C07JLT363ME/p1724767269456019?thread_ts=1724748364.070099&cid=C07JLT363ME

@xcoulon
Copy link
Contributor

xcoulon commented Sep 2, 2024

I'm curious, how can we make sure that all hackathon users will have verification required (so they have a chance to input the Activation Code)

@xcoulon I think Matous explained it here: https://redhat-internal.slack.com/archives/C07JLT363ME/p1724767269456019?thread_ts=1724748364.070099&cid=C07JLT363ME

I believe this was rather a 1-time hack to verify the workflow. But @alexeykazakov mentioned a more permanent solution in Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants