Made UserSignup.Spec.IdentityClaims property required #405
Conversation
sbryzak
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
mfrancisc
as code owners
pkg/configuration/configuration.go
Outdated
| @@ -178,7 +178,7 @@ func (r AuthConfig) AuthClientConfigRaw() string { | |||
| } | |||
|
|
|||
| func (r AuthConfig) AuthClientPublicKeysURL() string { | |||
| return commonconfig.GetString(r.c.AuthClientPublicKeysURL, "https://sso.devsandbox.dev/auth/realms/sandbox-dev/protocol/openid-connect/certs") | |||
There was a problem hiding this comment.
Is it a new keycloak thing? Or specific to our dev sso configuration?
We do rely on auth/realms path in a few places which is consistent with our production sso.redhat.com.
If we have a different path in dev sso then it won't work OOTB.
See https://github.com/search?q=repo%3Acodeready-toolchain%2Fregistration-service+%22auth%2Frealms%22&type=code
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, mfrancisc, rajivnathan, sbryzak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 78.14% 78.14%
=======================================
Files 38 38
Lines 3294 3294
=======================================
Hits 2574 2574
Misses 624 624
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Associated API PR: codeready-toolchain/api#400
E2E tests: codeready-toolchain/toolchain-e2e#900