Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate UserSignup.Spec.IdentityClaims from user's access token #347

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

sbryzak
Copy link
Contributor

@sbryzak sbryzak commented Sep 12, 2023

This PR modifies registration service to populate the UserSignup.Spec.IdentityClaims property with values extracted from the user's access token upon new user signup or user reactivation.

Fixes https://issues.redhat.com/browse/SANDBOX-381

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
12.3% 12.3% Duplication

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, sbryzak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,sbryzak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
pkg/signup/service/signup_service.go 100.00%

📢 Thoughts on this report? Let us know!.

@sbryzak sbryzak merged commit 2600366 into codeready-toolchain:master Sep 13, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants