add toolchainclusterresources controller #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancisc
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
sbryzak
as code owners
alexeykazakov
approved these changes
Apr 4, 2024
|
/retest |
MatousJobanek
approved these changes
Apr 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/retest |
|
/retest infra |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #555 +/- ##
=======================================
Coverage 84.06% 84.06%
=======================================
Files 29 29
Lines 2636 2636
=======================================
Hits 2216 2216
Misses 277 277
Partials 143 143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the toolchainclusterresources controller that will create all the required resources for the toolchaincluster CR.
The resources are defined as
embed.FStype indeploy.ToolchainClusterTemplateFSvariableThe add-cluster script will be cleaned up once this PR and the equivalent one in host-operator will be merged.
Depends on: codeready-toolchain/toolchain-common#385
e2e: codeready-toolchain/toolchain-e2e#946
Jira: https://issues.redhat.com/browse/KUBESAW-24