Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing binding request field #480

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

mfrancisc
Copy link
Contributor

generated files from codeready-toolchain/api#378

@openshift-ci openshift-ci bot added the approved label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #480 (e07298b) into master (77d165e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #480   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files          30       30           
  Lines        3444     3444           
=======================================
  Hits         2825     2825           
  Misses        474      474           
  Partials      145      145           

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mfrancisc mfrancisc merged commit 8b99ad2 into codeready-toolchain:master Oct 10, 2023
13 of 14 checks passed
@mfrancisc mfrancisc deleted the addsbrname branch October 10, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants