Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure that registration-service role matches the cache #1089

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions deploy/registration-service/registration-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ objects:
name: registration-service
namespace: ${NAMESPACE}
rules:
# !!! IMPORTANT !!!
# If there is a new resource added to this role, then revisit the registration-service client cache
# and make sure that the cache is pre-populated with all resources of this new kind.
# See: https://github.com/codeready-toolchain/registration-service/blob/36ce810d4c4cd68dc100646e8060ec94ae846f52/cmd/main.go#L192-L204
- apiGroups:
- toolchain.dev.openshift.com
resources:
Expand All @@ -31,7 +35,16 @@ objects:
- apiGroups:
- toolchain.dev.openshift.com
resources:
- "*"
- masteruserrecords
- socialevents
- spacebindings
- spaces
- toolchainconfigs
- toolchainstatuses
- proxyplugins
- nstemplatetiers
- bannedusers
- toolchainclusters
verbs:
- get
- list
Expand All @@ -40,11 +53,11 @@ objects:
- ""
resources:
- secrets
- configmaps
verbs:
- get
- list
- watch
# !!! IMPORTANT - see the comment above !!!
- kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
Expand Down
Loading