Skip to content

Commit

Permalink
Adding domains field to auto-approval config (#414)
Browse files Browse the repository at this point in the history
* Adding domains field to auto-approval config

Implements: ASC-444

Signed-off-by: David Peraza <[email protected]>

* Adding more description to the domains field.

Adding more descriptions to how domains will work with enabled.

Signed-off-by: David Peraza <[email protected]>

* Changing the domain examples to be more generic

We want to start moving into a more inviting code base.

Signed-off-by: David Peraza <[email protected]>

---------

Signed-off-by: David Peraza <[email protected]>
Co-authored-by: Alexey Kazakov <[email protected]>
  • Loading branch information
dperaza4dustbit and alexeykazakov authored Apr 25, 2024
1 parent d485db5 commit d0a6da0
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 0 deletions.
8 changes: 8 additions & 0 deletions api/v1alpha1/toolchainconfig_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,14 @@ type AutomaticApprovalConfig struct {
// Defines if the automatic approval is enabled or not
// +optional
Enabled *bool `json:"enabled,omitempty"`

// Comma-separated email domains to consider for auto-approval.
// For example: "domain.com,anotherdomain.org"
// If domains is not set and enabled is true, it will default to auto approving all authenticated emails.
// If domains is set and enabled is true, it will allow auto approving only for authenticated emails under
// the domains entered. If enabled is false domains will be ignored.
// +optional
Domains *string `json:"domains,omitempty"`
}

// DeactivationConfig contains all configuration parameters related to deactivation
Expand Down
5 changes: 5 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions api/v1alpha1/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d0a6da0

Please sign in to comment.